Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package name #148

Closed
sharmapukar217 opened this issue Nov 5, 2022 · 2 comments
Closed

Package name #148

sharmapukar217 opened this issue Nov 5, 2022 · 2 comments
Labels
question Further information is requested

Comments

@sharmapukar217
Copy link

I tried this with some other react framework and since this support all react framework, shouldn't the name be "react-themes" and also next is not used , i think that can be renoved from peer dependency 🤔
@pacocoursey
Copy link
Owner

This package was never intended to be used outside of Next.js. It's become generic enough for that to happen, but I haven't really considered it as a primary use case yet. Maybe in the future we can make it be react-themes and drop the next dep!

@pacocoursey pacocoursey added the question Further information is requested label Nov 7, 2022
@sharmapukar217
Copy link
Author

Sure then, I'm closing this issue as this issue was raised just to bring the maintainer's focus on this topic 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pacocoursey @sharmapukar217