Callback Version of setTheme Passes Itself

[ryanagillie]

Trying to use the callback version of setTheme and noticed that the callback function is being passed to itself

const { setTheme } = useTheme();

const onClick = () => {
  setTheme((pTheme) => {
    console.log(pTheme);
    return pTheme === 'dark' ? 'light' : 'dark';
  })
}

return (
  <button type="button" onClick={onClick}>Click me!</button>
)

After digging through the code:

this looks to be a simple fix, just need to change 2 things

1. the useCallback parameter name from theme to something else (value is usually the convention for setState like function), as currently if it's a function it's being called with itself (and not the actual theme, which is defined above)
2. add theme to callback array (and remove forcedTheme) so it'll always be up to date

[trm217]

Thanks for reporting this oversight!