Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next 11 compatibility and flashing issues #60

Closed
equinusocio opened this issue Sep 28, 2021 · 0 comments
Closed

Next 11 compatibility and flashing issues #60

equinusocio opened this issue Sep 28, 2021 · 0 comments

Comments

@equinusocio
Copy link

equinusocio commented Sep 28, 2021

It seems that this package doesn't work with nextjs 11.

Bug

I'm doing SSG with next 11.1.2 and gh-pages, but the theme is still flashing. For example, if you have a dark theme on the OS level, and you set the website to be light, you will see the dark one flashing before loading the light one and applying the data attribute.

Cause

I've checked other websites using this packages, and they are all using next 10. Also, maybe this can be the issue here, the script tag inside head is generated with a wrong and hashed type on next 11, this doesn't occur with next 10.

This is the screen viewing the page source.
Screenshot 2021-09-28 at 08 17 48

Another issue is that this package still puts scripts inside Head, while on next 11 we should use the Script component

Live

https://design.wonderflow.ai/

Repository

https://github.com/wonderflow-bv/design

@equinusocio equinusocio changed the title Next 11 compatibility Next 11 compatibility and flashing issues Sep 28, 2021
@equinusocio equinusocio changed the title Next 11 compatibility and flashing issues Next 11.1.2 compatibility and flashing issues Sep 28, 2021
@equinusocio equinusocio changed the title Next 11.1.2 compatibility and flashing issues Next 11 compatibility and flashing issues Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant