Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Write config parser #4

Closed
wizard-28 opened this issue Mar 26, 2022 · 1 comment
Closed

Write config parser #4

wizard-28 opened this issue Mar 26, 2022 · 1 comment
Assignees
Labels
config Related to the config parser enhancement New feature or request high priority High priority issue
Milestone

Comments

@wizard-28
Copy link
Member

wizard-28 commented Mar 26, 2022

The config file should be in the toml format, and should be stored in /etc/pacstall/config.toml (allow this location to be customized).

Progress:

@wizard-28 wizard-28 added the enhancement New feature or request label Mar 26, 2022
@wizard-28 wizard-28 added this to the 0.1.0 milestone Mar 26, 2022
@wizard-28 wizard-28 changed the title Add config parser Write config parser Mar 26, 2022
@wizard-28
Copy link
Member Author

We should use tomli as this is the fastest pure python parser.

Article comparing toml parsers.

Benchmark:

------------------------------------------------------
    parser |  exec time | performance (more is better)
-----------+------------+-----------------------------
     rtoml |    0.891 s | baseline (100%)
  pytomlpp |    0.969 s | 91.90%
     tomli |        4 s | 22.25%
      toml |     9.01 s | 9.88%
     qtoml |     11.1 s | 8.05%
   tomlkit |       63 s | 1.41%

@wizard-28 wizard-28 added config Related to the config parser high priority High priority issue labels Mar 26, 2022
@wizard-28 wizard-28 self-assigned this Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config Related to the config parser enhancement New feature or request high priority High priority issue
Projects
Development

No branches or pull requests

1 participant