Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock->shouldAllowMockingMethod() returns $this instead of null #333

Merged
merged 4 commits into from
May 16, 2014

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented May 15, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) when pulling 9afb1af on fhinkel:master into 7157218 on padraic:master.

/**
* Allows additional methods to be mocked that do not explicitly exist on mocked class
* @param String $method name of the method to be mocked
* @return $this
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually according to PHPDoc syntax the $this value isn't allowed. You should use either self (exactly this class instance) or static (extended class instance).

davedevelopment added a commit that referenced this pull request May 16, 2014
Mock->shouldAllowMockingMethod() returns $this instead of null
@davedevelopment davedevelopment merged commit 2169d21 into mockery:master May 16, 2014
@davedevelopment
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants