Fix/overloading fully qualified names #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedevelopment
added a commit
that referenced
this pull request
Dec 24, 2014
…ied-names Fix/overloading fully qualified names
|
Awesome! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I caught a bug yesterday when overloading classes.
If the overloading was done with
Mockery::mock('overload:\MyNamespace\Class'), PHP would trigger a somewhat criptic error:PHP Fatal error: Undefined constant 'MyNamespace' in /home/robert/www/mockery/library/Mockery/Loader/EvalLoader.php(16) : eval()'d code on line 21This fix left trims the backslash from the namespace name to generate valid PHP code.
P.S.: New code looks sweet! It was very easy to find and fix the bug :)