Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Updates for PHP 7.1 #631

Merged
merged 6 commits into from
Oct 25, 2016
Merged

Conversation

davedevelopment
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 76.033% when pulling 1afd844 on davedevelopment:7.1 into 15dc926 on padraic:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 76.033% when pulling 820911c on davedevelopment:7.1 into 15dc926 on padraic:master.

Copy link

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still something left to support 7.1:

  • nullable return types,
  • iterable pseudotype.

$typeHint = '\\'.$typeHint;
}

if ($param->allowsNull()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not work on 7.0 when parameter has NULL default value (would generate invalid code). I'd suggest also checking whether default value is available and is not NULL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Majkl578 think I cover things in 1c05aac.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 75.992% when pulling 1c05aac on davedevelopment:7.1 into 15dc926 on padraic:master.

@grogy
Copy link

grogy commented Oct 24, 2016

How looks state of this PR? Can I help or will be PR merged?

@davedevelopment
Copy link
Collaborator Author

@grogy I think the state is probably good (travis build fails are because travix was on an older 7.1 RC I think), it's more a case of if there is any other business with regards to 7.1. I could probably merge this and create subsequent PRs as they come up.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 76.029% when pulling d3bc6dd on davedevelopment:7.1 into 15dc926 on padraic:master.

@davedevelopment davedevelopment merged commit 1d397a4 into mockery:master Oct 25, 2016
@davedevelopment
Copy link
Collaborator Author

Merged, will open new PRs as they come

@danwdart
Copy link

Has there been a release since? I'm still getting the error in issue #635 on version 0.9.6.

@davedevelopment
Copy link
Collaborator Author

@kathiedart there hasn't, but I don't plan on merging this back to the 0.9 branch. I'd recommend working from master for now if you want 7.1 support.

@danwdart
Copy link

OK thanks. That's what we're doing now

@bruli
Copy link
Contributor

bruli commented Feb 6, 2017

Any idea when you will can publish a new version with php7.1 return types support?.

@davedevelopment
Copy link
Collaborator Author

@bruli working on it, but don't have a planned release date yet, you'll need to work from the master branch for now.

@bruli
Copy link
Contributor

bruli commented Feb 6, 2017

I wish it, but I can't update from the master branch because in my project we are using a third party library that use last stable version.

@davedevelopment
Copy link
Collaborator Author

@bruli ah ok. Well, my focus is on building up to 1.0, but if anyone wants to port these to the 0.9 branch and open a PR, I'll get it merged and tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants