-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Updates for PHP 7.1 #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still something left to support 7.1:
- nullable return types,
- iterable pseudotype.
$typeHint = '\\'.$typeHint; | ||
} | ||
|
||
if ($param->allowsNull()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will not work on 7.0 when parameter has NULL default value (would generate invalid code). I'd suggest also checking whether default value is available and is not NULL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How looks state of this PR? Can I help or will be PR merged? |
@grogy I think the state is probably good (travis build fails are because travix was on an older 7.1 RC I think), it's more a case of if there is any other business with regards to 7.1. I could probably merge this and create subsequent PRs as they come up. |
Merged, will open new PRs as they come |
Has there been a release since? I'm still getting the error in issue #635 on version 0.9.6. |
@kathiedart there hasn't, but I don't plan on merging this back to the 0.9 branch. I'd recommend working from master for now if you want 7.1 support. |
OK thanks. That's what we're doing now |
Any idea when you will can publish a new version with php7.1 return types support?. |
@bruli working on it, but don't have a planned release date yet, you'll need to work from the master branch for now. |
I wish it, but I can't update from the master branch because in my project we are using a third party library that use last stable version. |
@bruli ah ok. Well, my focus is on building up to 1.0, but if anyone wants to port these to the 0.9 branch and open a PR, I'll get it merged and tagged. |
No description provided.