Fix withNoArgs() to work with PHP 7.2 #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
suggested changes
Nov 29, 2016
| @@ -330,7 +330,8 @@ protected function _matchArg($expected, &$actual) | |||
| } | |||
| if (is_string($expected) && !is_array($actual) && !is_object($actual)) { | |||
| # push/pop an error handler here to to make sure no error/exception thrown if $expected is not a regex | |||
| set_error_handler(function () {}); | |||
| set_error_handler(function () { | |||
| }); | |||
There was a problem hiding this comment.
that makes no difference for php 7.2
There was a problem hiding this comment.
I fixed it because styleCI complained, no other reason
GrahamCampbell
approved these changes
Nov 29, 2016
|
Thanks! |
|
I have rerun the travis project that tests this feature, and I am happy to report that this has resolved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest way I could think of of fixing #645 .