-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged all travis configuration into one file to improve maintainability #678
Conversation
I assume that's because the services we upload the coverage to have 1 build per commit, rather than travis which gives you multiple "sub" builds. I don't know much about coveralls and I've not used the coverage uploader for scrutinizer before either.
7073e80 suggests it was originally I take it this supersedes #677? 👍 from me, I don't care for the separate files. |
@davedevelopment Well spotted, this does indeed incorporate the changes from #677. Therefore, please merge this instead to avoid conflicts.
That is definitely not the case for Coveralls. Not sure about Scrutinizer, but from what I recall, it is not true for that service either. Both Coveralls and Scrutinizer are built with Travis integration in mind and Travis has supported multiple builds per commit since the beginning. I may address this in a future PR.
The opposite. The final
It occurred to me whilst merging there exists the possibility that the original author did not, either. Perhaps they just did not know how to express their script in YAML format. |
Merged, thanks!
Are you sure? I know the |
Ah. I didn't actually look at the config! I still don't understand it at all. I see no reason why it should be excluded, particularly on a per-version basis, so I think it can just be removed right now on master. |
Merging all the Travis configuration into one file gives us a better overview of what is actually happening and thus improves maintainability of the Travis build. This configuration is mostly unchanged from the original, but as an added bonus, installation of satooshi/php-coveralls was moved to the after_success step because it is not needed of the build fails and coverage is never generated, thus speeding up the build.
There are still quirks, errors and optimizations to be done but I will submit them after this has been merged. For example:
MockeryPHPUnitIntegration
stripped from the PHP 5.6 build?