Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpStorm and magic __call methods #710

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Conversation

unglud
Copy link

@unglud unglud commented Mar 8, 2017

Problem: PhpStorm not always can follow to __call method and inspector may yell that it can not find method.
before

Solution: Add PHPDoc with methods descriptions
after

…r may yell that it can not find method.

Solution: Add PHPDoc with methods descriptions
@davedevelopment
Copy link
Collaborator

Will merge this as a quick fix, but I think the better way would be to fix the interface and anything that implements it. This would break BC, but it's a shallow break, ExpectationInterface can be marked as @internal going forward.

I've actually written about making the experience better here, but my implementation at the time branched off in to a completely new project

Blog Post: http://davedevelopment.co.uk/2014/11/03/designing-a-dsl-with-interfaces.html
Toy Project: https://github.com/davedevelopment/sham

@davedevelopment davedevelopment merged commit ad5bbff into mockery:master Mar 10, 2017
@unglud
Copy link
Author

unglud commented Mar 10, 2017

I agree it's more a hack, then fix. I'll look at your links, and may be came to some more right way.
Thank you.

@davedevelopment
Copy link
Collaborator

@unglud no problem, I wasn't suggesting you look at it, more a note for myself or anyone else who happens to be passing by. Obviously you are more than welcome to take a look, just want to be clear I'm not trying to push you in to anything :)

@unglud
Copy link
Author

unglud commented Mar 10, 2017

You will not stop me make this better! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants