error do ... end doesn't seem to work for a default error handler

[udzura]

Dear Team,

I tryed to catch all exceptions by error do ... end block, but I found the code like below:

class App < Padrino::Application
  #...
  configure :production do
    error ::Exception do
      Padrino.logger.error "Catching #{env['sinatra.error'].class}."
      # some logging...
      erb :'errors/500'
    end
  end
end

doesn't work on production.

I guess this is because the error ::Exception do ... end block is overrided by Padrino::Application.default_errors!

https://github.com/padrino/padrino-framework/blob/master/padrino-core/lib/padrino-core/application.rb#L212

And for example, this code works.

class App < Padrino::Application
  #...
  def self.default_errors!
    configure :production do
      error ::Exception do
        Padrino.logger.error "Catching #{env['sinatra.error'].class}."
        # some logging...
        erb :'errors/500'
      end
    end
  end
end

I hope Padrino::Application.default_errors! won't override the "::Exception" error block when error Exception do is already declared.

Thank you,
Uchio Kondo

[DAddYE]

@udzura try with this:

error 500 do
  ...

[udzura]

Thanks for advise, and an elegant commit!