Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use devDependencies #22

Closed
vcapretz opened this issue Nov 7, 2017 · 2 comments
Closed

use devDependencies #22

vcapretz opened this issue Nov 7, 2017 · 2 comments
Assignees

Comments

@vcapretz
Copy link
Contributor

vcapretz commented Nov 7, 2017

all packages on package.json are currently placed inside "dependencies", we should use "devDependencies" as well, so for production envs or builds we could save time/storage.

I am not sure which packages can be placed in devdependencies and if it's really needed.

my first thoughts were:
babel and lint packages, webpack-dev-server, storybook

@thgmhz
Copy link
Contributor

thgmhz commented Nov 7, 2017

Makes sense. The project was bootstrapped with create-react-app which places all packages in 'dependencies'.

@derekstavis what do you think about?

@augusto-jm-amaral
Copy link
Collaborator

It does not make sense to be in dependencies because when they use the module all dependencies will go into the tree.

Once we are using webpack the dependencies needed to execute the project will be contained in the bundle.

I did a build of the module using the only devDenpencies and I had no problems adding it to another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants