Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Editor dissapears #551

Closed
Eichi opened this issue Feb 28, 2016 · 3 comments
Closed

Editor dissapears #551

Eichi opened this issue Feb 28, 2016 · 3 comments
Assignees

Comments

@Eichi
Copy link

Eichi commented Feb 28, 2016

Hi,

today I got a new interesting bug, when adding following valid html code in a page or widget
`


Impressum & Datenschutz - Kontakt

` the editing page dosn't load after reloading the site so I had to remove the content in the db to get access to the editor again. The site ist empty only the menubar is shown.

Even with debugging enabled I got no error, only a white page came up. But after some trying I found out, that the single quotes ' are not escaped well by pagekit, after inserting double quotes " it worked again as expected.

https://www.w3.org/TR/html4/intro/sgmltut.html#h-3.2.2
https://xkcd.com/327/

@floriandotpy
Copy link
Contributor

I looked into this. The editor now no longer disappears. 49b68d2

However, the URLs in single quotes are rewritten incorrectly when the editor is loaded (they should not be rewritten at all in this case). So this issue needs some more work.

@floriandotpy
Copy link
Contributor

URL rewriting is now limited to body content which ensures that the JSON in the head section no longer breaks. 84d9a3a

@malte-christian
Copy link
Contributor

I think the main problem was that JSON embedded inside script tags was not RFC4627-compliant, therefor rewriting was possible.
I changed the JSON encoding options according to the encoding options of Symfonys JSONResponse
(f2849e7).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants