Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificates are not yet verified #6

Open
pagekite opened this issue Jan 8, 2014 · 2 comments
Open

SSL certificates are not yet verified #6

pagekite opened this issue Jan 8, 2014 · 2 comments
Labels

Comments

@pagekite
Copy link
Owner

pagekite commented Jan 8, 2014

When connecting with HTTPS, the SSL certs are not yet verified, making the whole thing insecure.

@pagekite
Copy link
Owner Author

pagekite commented Mar 7, 2016

Further details on this. In order to fix this issue, libpagekite needs to support the following:

- Discovery & use of OS certificate authority stores.
- Support for a TOFU model of some sort.
- Specification of acceptable certificate details (fingerprints, names) via. API methods.

Whether we use TOFU or the standard SSL PKI (CA certs) model is an unanswered question at this point; PKI is the standard but it has some nasty failure modes.

This is a particularly sensitive part of the app, because if we refuse connections because a certificate doesn't validate, there is a risk of false positives taking customer devices offline. So although security is important, we don't want to make things less reliable.

@BjarniRunar
Copy link
Collaborator

Progress was made in b8fba94, f5f2670, 3e06b51, 6d80418 ... but we're not there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants