fix: allow empty payloads #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IJuanI
reviewed
Nov 3, 2022
IJuanI
approved these changes
Nov 7, 2022
sa-pagerinc-automation
pushed a commit
that referenced
this pull request
Nov 7, 2022
## [5.4.4](v5.4.3...v5.4.4) (2022-11-07) ### Bug Fixes * allow empty payloads ([#942](#942)) ([af1e3ae](af1e3ae))
|
🎉 This PR is included in version 5.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-7564
If a payload is empty or is malformed JSON, then the consumer callback should still be invoked (with the empty payload). If an empty payload was not expected, then downstream validation can NACK the message.