Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Memory Usage on Alias Admin page #571

Open
DanrwAU opened this issue Sep 17, 2023 · 13 comments · Fixed by #574
Open

High Memory Usage on Alias Admin page #571

DanrwAU opened this issue Sep 17, 2023 · 13 comments · Fixed by #574
Labels
Projects

Comments

@DanrwAU
Copy link
Member

DanrwAU commented Sep 17, 2023

Describe the bug
Large memory usage when loading the "Alias" admin page when a large number of aliases are defined.

Tied to fontawesome. does not happen when fontawesome is disabled. suspect number of icons loading has a significant impact

To Reproduce
Load a significant number of aliases in with Icons defined.
Load Alias page, browser will consume high amounts of memory, with a large numebr of aliases this will also crash the browser with an "out of memory" error

Expected behavior
Works

Additional context
Possible solutions https://fontawesome.com/docs/web/add-icons/svg-symbols

@DanrwAU DanrwAU added the bug label Sep 17, 2023
@marshyonline marshyonline added this to Next in PagerMon Sep 17, 2023
@DanrwAU
Copy link
Member Author

DanrwAU commented Sep 27, 2023

fixed in #572 - rolled back to FontAwesome 4 - breaking change

@DanrwAU DanrwAU mentioned this issue Sep 29, 2023
7 tasks
@aaronchitaranjan
Copy link

@DanrwAU possible solution that seems to work for me, is to change the 'Technology' of the FA Kit to Web Fonts instead of SVG. I'm getting dramatically improved alias page loads with 700+ aliases

@bullseye555
Copy link

@DanrwAU and @aaronchitaranjan - I've tried this too (after seeing the suggestion!) with 9000 odd capcodes.

Only issue has been some icons not loading, but for the sake of having the Alias page loading, I'll happily change the one icon that's not loading!

@aaronchitaranjan
Copy link

@DanrwAU and @aaronchitaranjan - I've tried this too (after seeing the suggestion!) with 9000 odd capcodes.

Only issue has been some icons not loading, but for the sake of having the Alias page loading, I'll happily change the one icon that's not loading!

Good to hear. Might be worth adding it to the README/settings page if more people report similar positive results 🤷

@Shaggs
Copy link
Contributor

Shaggs commented Jan 9, 2024

Have the same issue. Opening alias crashes with 1070 CAPcodes 😳.

Refreshing CAPcodes is also an issue.

Have issues on rpi and i5 16gb RAM (testing to see if it was a memory issue).

Looks to be a limitation with node?

@aaronchitaranjan
Copy link

Have the same issue. Opening alias crashes with 1070 CAPcodes 😳.

Refreshing CAPcodes is also an issue.

Have issues on rpi and i5 16gb RAM (testing to see if it was a memory issue).

Looks to be a limitation with node?

Did changing the icon pack technology help?

@Shaggs
Copy link
Contributor

Shaggs commented Jan 9, 2024

Did changing the icon pack technology help?

As in changing from webfonts to svg? Not yet reading now how to do it.

@Shaggs
Copy link
Contributor

Shaggs commented Jan 9, 2024

I had it set to SVG now changed to web font.

@aaronchitaranjan
Copy link

I had it set to SVG now changed to web font.

Let us know how you go :)

@Shaggs
Copy link
Contributor

Shaggs commented Jan 9, 2024

I had it set to SVG now changed to web font.

Let us know how you go :)

Yeah that fixed it. 👍

@s3m1s0n1c
Copy link
Member

s3m1s0n1c commented Jan 9, 2024

I fixed it by using
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.css" integrity="sha512-5A8nwdMOWrSz20fDsjczgUidUBR8liPYU+WymTZP1lmY9G6Oc7HlZv156XqnsgNUzTyMefFTcsFH/tnJE/+xBg==" crossorigin="anonymous" referrerpolicy="no-referrer" /> in header.ejs
instead of the one in there..

@gg33fr
Copy link

gg33fr commented Feb 27, 2024

Hello, when I add aliases, and I do a refresh I have the circle that turns on the page and the refresh does not take place.
This actually looks like a memory problem.
I added the command line given by s3m1s0n1c, maybe I did it wrong.
Can you put the entire header.ejs file
I am on the PagerMon 0.3.11-beta version with a pi 4 - 1GB
Thanks

@Shaggs
Copy link
Contributor

Shaggs commented Mar 10, 2024

Hello, when I add aliases, and I do a refresh I have the circle that turns on the page and the refresh does not take place. This actually looks like a memory problem. I added the command line given by s3m1s0n1c, maybe I did it wrong. Can you put the entire header.ejs file I am on the PagerMon 0.3.11-beta version with a pi 4 - 1GB Thanks

Just change to Web font.. much easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

6 participants