Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Support unix domain sockets for memcached #467

Closed
oschaaf opened this issue Aug 2, 2013 · 3 comments
Closed

Support unix domain sockets for memcached #467

oschaaf opened this issue Aug 2, 2013 · 3 comments

Comments

@oschaaf
Copy link
Member

oschaaf commented Aug 2, 2013

From https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/XBEopX--kH8
I would be nice to support unix domains for memcached.
Looking at apr_memcache2.c, I don't think it would be very hard to add it.

@oschaaf
Copy link
Member Author

oschaaf commented Aug 2, 2013

@jeffkaufman to support this, a change is required in /src/third_party/aprutil/apr_memcache2.c [1]

Can I look at adding that? Or are unix sockets deliberately not supported?

[1] http://mail-archives.apache.org/mod_mbox/apr-commits/201305.mbox/%3C20130519113105.F0A1D238897A@eris.apache.org%3E

@jeffkaufman
Copy link
Contributor

This would be nice to add, but I think it makes less sense for you to do it than someone who can change third_party/aprutil/apr_memcache2.c. That way both nginx and apache get support.

We should probably look at the diffs for apr_memcache.c and our apr_memcache2.c and see if there are any other changes we need (or, really, if there are any other changes we don't need).

@jeffkaufman
Copy link
Contributor

Moved to mod_pagespeed issue tracker as issue 760.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants