Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Call async_fetch_->Done after all usages. #919

Merged

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Feb 17, 2015

AsyncFetch::Done will delete itself. Accessing
async_fetch_->extra_respond_headers() will crash nginx.

Updated @Basek his patch from #755
to apply to the current codebase.

AsyncFetch::Done will delete itself. Accessing
async_fetch_->extra_respond_headers() will crash nginx.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@oschaaf
Copy link
Member Author

oschaaf commented Feb 17, 2015

@bacek Again, thanks for the patch - and sorry for merging this in so late!
Could you sign the CLA?

@bacek
Copy link
Contributor

bacek commented Feb 17, 2015

Hello Otto.

I did sign CLA electronically. Long time ago
On 18 Feb 2015 9:30 am, "Otto van der Schaaf" notifications@github.com
wrote:

@bacek https://github.com/bacek Again, thanks for the patch - and sorry
for merging this in so late!
Could you sign the CLA?


Reply to this email directly or view it on GitHub
#919 (comment)
.

@oschaaf
Copy link
Member Author

oschaaf commented Feb 18, 2015

@bacek thanks, I didn't know. In that case, @jeffkaufman LGTY?

@jeffkaufman
Copy link
Contributor

LGTM

@bacek Looks like a bug in our CLA-checker; I'll report it.

oschaaf added a commit that referenced this pull request Feb 18, 2015
…fetcher-pull-755

Call async_fetch_->Done after all usages.
@oschaaf oschaaf merged commit bcba22d into trunk-tracking Feb 18, 2015
@oschaaf oschaaf deleted the oschaaf-trunk-tracking-native-fetcher-pull-755 branch February 18, 2015 12:38
@jeffkaufman
Copy link
Contributor

I talked to the people who work on @googlebot, and it looks like you got this message because while it can see that @bacek did sign the CLA it wants to make sure that he's ok with these commits being contributed to our repo.

(For example, say I sign the CLA because I'm working on google project X. Then I write some commits on my own for personal project Y, and someone else takes them and submits a pull request for X. It makes sense to check with me that I'm ok with my change being included in X, even though I did give permission for any code I contribute directly.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants