Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom logger in _ForwardServer #250

Merged
merged 1 commit into from May 14, 2023
Merged

Conversation

sweenu
Copy link
Contributor

@sweenu sweenu commented Dec 26, 2021

It's problematic that we're doing create_logger() hidden in the __init__ of _ForwardServer because it modifies the custom logger that we might be passing when creating an SSHTunnelForwarder by adding a console handler.
We do not always want a console handler.

@coveralls
Copy link

coveralls commented Dec 26, 2021

Coverage Status

Coverage increased (+0.3%) to 91.754% when pulling 1d054c3 on sweenu:use_custom_logger into 58a46ef on pahaz:master.

@pahaz pahaz merged commit ba25626 into pahaz:master May 14, 2023
@pahaz
Copy link
Owner

pahaz commented May 14, 2023

Welcome to the CONTRIBUTOR list: d2160ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants