Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty cells are treated as zeros, all statistics are therefore wrong #54

Closed
demarant opened this issue Aug 19, 2017 · 2 comments
Closed

Comments

@demarant
Copy link

demarant commented Aug 19, 2017

I have uploaded a CSV with empty cells, on the demo site at https://pair-code.github.io/facets/
but all the empty cells are treated as zeros and therefore the calculated statistical values like mean,median, st.dev are wrong.

See attached Handelsbanken_fonder_DB.xlsx file, e.g. the column "10 ar" contains many (337) empty cells, with no value, but these are wrongly treated as 0 by facets. The median should be 59.4, but facets gives instead 31.5.

Handelsbanken_fonder_DB.xlsx

expected is that empty cells are counted as "missing / nodata" and not used in the statistical calculations.

@jameswex
Copy link
Collaborator

Thanks for pointing this out, I'll take a look this week

@jameswex
Copy link
Collaborator

Fixed the issue in the demo website code that caused blank cells in a csv to be treated as zeros. Just pushed fixed so demo site should handle your case correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants