Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data split for binning - Datapoint editor vs. Performance & Fairness #53

Open
timoei opened this issue Feb 24, 2020 · 1 comment
Open
Labels
bug Something isn't working

Comments

@timoei
Copy link

timoei commented Feb 24, 2020

Hi,

we really like to use the What-If tool. The last days we encountered that the split of the data between the datapoint editor and the performance and fairness tabs isn't performed in the same way. As an example, we binned the data of the UCI census income dataset by age in 10 bins. The number of data points in each bin for the datapoint editor and performance & fairness tabs can vary (s. figure).
whatIf_bins

For us, it would be extremely helpful if the data in e.g. the first bin of the datapoint editor would be exactly the same as in the first bin of the performance and fairness tab.

Best,
Timo

@jameswex
Copy link
Collaborator

Thanks so much for this feedback. You're correct that the binning logic in the Performance & Fairness tab is a little different than that in the datapoints display. This is due to the fact that the datapoints display uses the Facets Dive visualization which has its own binning logic outside of the What-If Tool code repository.

But, it should be possible for us to unify the binning logic between the two. This issue will track the work of unifying them.

@jameswex jameswex added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants