Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility of async methods? #107

Closed
gswalden opened this issue Feb 3, 2017 · 2 comments
Closed

Possibility of async methods? #107

gswalden opened this issue Feb 3, 2017 · 2 comments

Comments

@gswalden
Copy link
Contributor

gswalden commented Feb 3, 2017

Has there been any investigation into whether we could implement asynchronous methods in this library, similar to bcrypt? I'm hesitant to run this as a password hashing library on a production server, knowing it will block the event loop for 100-300ms every time a user attempts to login.
@paixaop
Copy link
Owner

paixaop commented Feb 6, 2017

This would be great but the lib is somewhat big and right now I have no time to do a full rewrite to support async methods. If you want to start down that path it would be awesome.

@gswalden
Copy link
Contributor Author

gswalden commented Feb 8, 2017

Got it!

@gswalden gswalden closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paixaop @gswalden