Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distzip does not presently work when build output is a directory or multiple files #98

Open
3 tasks
dmikusa opened this issue Mar 31, 2022 · 0 comments
Open
3 tasks
Labels
type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Mar 31, 2022

What happened?

The build tools buildpacks based on libbs were recently given the ability to consume multiple build artifacts. They can now specify a folder or multiple files. When this happens, the folder/multiple files are restored to /workspace/<files>, which creates a folder structure under /workspace that dist-zip cannot presently handle. At present, it expects /workspace/bin/* or something like that (exploded dist-zip).

The buildpack should support building from multiple artifacts. It would need to search through /workspace for zip archives, and examine the archive to see if it is a dist-zip archive (i.e. has a */bin/* folder). When found, extract the contents to /workspace and run it.

Checklist

  • I have included log output.
  • The log output includes an error message.
  • I have included steps for reproduction.
@dmikusa dmikusa added the type:enhancement A general enhancement label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant