Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'stable' for go versions in github actions #794

Closed
robdimsdale opened this issue Aug 2, 2023 · 0 comments · Fixed by #841
Closed

Use 'stable' for go versions in github actions #794

robdimsdale opened this issue Aug 2, 2023 · 0 comments · Fixed by #841
Labels
good first issue A good first issue to get started with hacktoberfest Hacktoberfest eligible

Comments

@robdimsdale
Copy link
Member

According to the setup-go action documentation, we can use:

  - uses: actions/setup-go@v4
    with:
      go-version: 'stable'

Instead of hard-coding a version of go and having to change that every few months when the versions of golang update.

I don't see a reason not to use stable. We want the buildpacks to be built with the latest stable; we don't need to validate that the buildpacks are able to be built with older versions of golang.

For libraries (e.g. packit, libnodejs, etc), we could expand this to a matrix support, consisting of stable and oldstable if we wanted to validate that the libraries still work fine on all supported versions of golang.

@sophiewigmore sophiewigmore added good first issue A good first issue to get started with hacktoberfest Hacktoberfest eligible labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with hacktoberfest Hacktoberfest eligible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants