-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for customizing color themes #1619
Comments
What else are you thinking besides light and dark modes? Note that you can already customize the entire color palette |
In my project I need 4 color themes - default, light, dark and yellow. Ideally, I'd like to have some option to add as many additional palettes as I want, without big changes of existing library code |
Disclaimer: I'm not on the Blueprint team The dark theme just added I'm not sure how much work it would be to refactor all the |
I dont want to change current codebase a lot. Of course, copying |
@AlexMarvelo creating custom themes is theoretically* possible by overriding SCSS variables and compiling a custom blueprint.css. You can even compile the entire project within a CSS class namespace, so all your custom styles would be inside Sass customization is officially unsupported by the team. We did our due diligence to allow overriding all variables by adding Prior discussions: #123, #184, #194. * never attempted but the pieces should be in place |
Thanks for explanations @giladgray |
@giladgray @llorca - my thought: can we close this? I don't see us prioritizing themes in a first-class way anytime soon (unless Palantir-internal teams suddenly happen to need Themes Number Three, Four, and Five), in which case we can just open a new ticket. |
(Closing aggressively for now; feel free to re-open if you vehemently disagree.) |
yeah, I view regular/ |
I guess it would be nice to provide the ability to add/customize a color theme. In many cases, we need more than light/dark themes only
What are your thoughts about relevance and implementation?
The text was updated successfully, but these errors were encountered: