Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangeInput -- incorrect endInputString when closeOnSelection=false #3081

Open
brendansudol opened this issue Oct 26, 2018 · 1 comment
Open

Comments

@brendansudol
Copy link

brendansudol commented Oct 26, 2018

Environment

  • Package version(s): 3.3.0
  • Browser and OS versions: Chrome, Mac

Steps to reproduce

  1. Add a DateRangeInput with closeOnSelection of false
  2. Click on a start date and then click on a valid end date
  3. The endInputString is cleared out, instead of being set to the clicked on end date.
  4. If you go on to click another end date, the endInputString becomes the second to last clicked on end date (not the most recent). It seems to be off by one every time (until you close the input)

Actual behavior

When you select an end date and the closeOnSelection is false (i.e., the popover stays open), the input string is not set to the clicked on date but the last clicked date (it's always one behind).

Expected behavior

The end date input string should reflect the most recently selected end date.

@adidahiya
Copy link
Contributor

This doesn't seem to happen on the docs site: https://blueprintjs.com/docs/#datetime/daterangeinput

Can you repro this in a code sandbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants