Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover's boundary prop does not accept Element objects #3570

Open
mmermerkaya opened this issue May 27, 2019 · 1 comment
Open

Popover's boundary prop does not accept Element objects #3570

mmermerkaya opened this issue May 27, 2019 · 1 comment

Comments

@mmermerkaya
Copy link

Package: @blueprintjs/core@3.15.1

Issue: The boundary field of IPopoverSharedProps (defined here) does not accept values of type Element.

Description: This field (boundary) is only used as the boundariesElement field in flip and preventOverflow objects in Popper modifiers, as seen here. Both of these fields in Popper (defined here and here) accept objects of type Boundary | Element, but the boundary field defined in Blueprint only accepts Boundary.

Possible Solution: Change the type here from PopperBoundary to PopperBoundary | Element.

@adidahiya
Copy link
Contributor

Good call, I think your solution would work. Would you be open to sending a quick PR? Ideally, add a small unit test to make sure it doesn't break the Popper instance at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants