Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLTable striped doesn't apply correct to row headers #3710

Open
Firehed opened this issue Aug 20, 2019 · 0 comments
Open

HTMLTable striped doesn't apply correct to row headers #3710

Firehed opened this issue Aug 20, 2019 · 0 comments

Comments

@Firehed
Copy link

Firehed commented Aug 20, 2019

Environment

  • Package version(s): 3.18
  • Browser and OS versions: macOS Safari 12

If possible, link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-stt6c

Steps to reproduce

<HTMLTable striped>
  <thead>...</thead>
  <tbody>
    <tr>
      <th>Some row header</th>
      <td>value</td>
      <!-- ... -->
    </tr>
  </tbody>
</HTMLTable>

Actual behavior

Table striping does not apply to <th> cells in <tbody>, only <td>. While not especially common, it's a valid placement according to the spec, and shown in numerous examples

Interactive tables exhibit similar issues.

Expected behavior

Header cells also receive striping behavior inside the tbody

Possible solution

Looks like it's a relatively minor change to some CSS selectors. However this also seems to impact interactive so a correct fix may be slightly wider-reaching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants