Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom configuration of scss stylelint rules #411

Closed
adidahiya opened this issue Jan 4, 2017 · 5 comments
Closed

Remove custom configuration of scss stylelint rules #411

adidahiya opened this issue Jan 4, 2017 · 5 comments
Milestone

Comments

@adidahiya
Copy link
Contributor

In particular, max-line-length and at-extend-no-missing-placeholder. This project isn't really special enough to skip those rules. We should either fix the violations or update stylelint-config-palantir to reflect how we really write code.

"scss/at-extend-no-missing-placeholder": null

@giladgray
Copy link
Contributor

what's wrong with max line length?

@adidahiya
Copy link
Contributor Author

Why do we need a custom line length limit? We should just use whatever is prescribed in stylelint-config-palantir.

@giladgray
Copy link
Contributor

do you really want me to rewrap all those documentation paragraphs? those are the only long lines.

@giladgray
Copy link
Contributor

the line length affects every single scss file

@giladgray
Copy link
Contributor

ok so 100-character lines are pretty reasonable even for the docs comments, but there are a few cases where longer lines are unavoidable (such as extremely long URLs) and it's cumbersome to disable stylelint for a block comment.

we could leverage the new ignore: ["comments"] option to allow our comments to be longer? http://stylelint.io/user-guide/rules/max-line-length/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants