Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect mutates incoming tagInputProps object #6645

Closed
jrafidi opened this issue Jan 10, 2024 · 1 comment · Fixed by #6653
Closed

MultiSelect mutates incoming tagInputProps object #6645

jrafidi opened this issue Jan 10, 2024 · 1 comment · Fixed by #6653
Assignees
@adidahiya
Labels
Package: select Type: bug

Comments

@jrafidi
Copy link
Contributor

jrafidi commented Jan 10, 2024

Environment

  • Package version(s): select@5.0.20
  • Operating System: OSX
  • Browser name and version: Chrome

Relevant code

https://github.com/palantir/blueprint/blob/develop/packages/select/src/components/multi-select/multiSelect.tsx#L259C1-L264C14

Is there a reason why this prop is mutated?
@adidahiya
Copy link
Contributor

Nope, that looks like an oversight. will fix

@adidahiya adidahiya self-assigned this Jan 12, 2024
@adidahiya adidahiya mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
Package: select Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[select] fix(MultiSelect): avoid mutating props.tagInputProps palantir/blueprint
2 participants
@adidahiya @jrafidi