Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumericInput doesn't pass down className props (or accept ".pt-large" modifier) #907

Closed
imawuman opened this issue Mar 30, 2017 · 4 comments

Comments

@imawuman
Copy link

Bug report

  • Package version(s): 1.13.0

Steps to reproduce

  1. Render NumericInput component with className prop
  2. <NumericInput className="pt-large"/>

Actual behavior

  1. Rendered class name is placed on div surrounding div.pt-control-group

Expected behavior

  1. Class name props are placed on div.pt-control-group element so that modifiers such as ".pt-large" work
@llorca
Copy link
Contributor

llorca commented Mar 30, 2017

@cmslewis quick fix?

@cmslewis
Copy link
Contributor

Making pt-large work on NumericInput's custom-styled vertical buttons will be a little kludgy, but barring that, this should be quick, yes.

@llorca
Copy link
Contributor

llorca commented Mar 30, 2017

Ha, true. I was playing in the inspector, see if we could make this behavior modifier-independent. Didn't have much success, but I do think it's possible to have those little buttons sized automatically whether it's pt-large or not. If we can't make that work, I'm happy to assist with pixel sizing for those small buttons in pt-large mode

@adidahiya
Copy link
Contributor

we'd accept a PR for this, but it's not a priority at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants