Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should WithRawResponseBody be opinionated about content type? #60

Open
najork opened this issue Sep 11, 2019 · 0 comments
Open

Should WithRawResponseBody be opinionated about content type? #60

najork opened this issue Sep 11, 2019 · 0 comments

Comments

@najork
Copy link
Contributor

najork commented Sep 11, 2019

WithRawResponseBody sets the Accept header to application/octet-stream. This can lead to 406 Not Acceptable responses if the endpoint doesn't support the advertised type, requiring clients to explicitly add additional types to the request header, which could be potentially confusing to consumers of this library.

https://github.com/palantir/conjure-go-runtime/blob/develop/conjure-go-client/httpclient/request_params.go#L124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@najork