Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track queue time/event age for async dispatch #42

Closed
bluekeyes opened this issue May 13, 2020 · 2 comments · Fixed by #52
Closed

Track queue time/event age for async dispatch #42

bluekeyes opened this issue May 13, 2020 · 2 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@bluekeyes
Copy link
Member

It would be nice to have a github.event.age metric or similar, that reports statistics about the age (amount of time spent in the queue) of webhook events. Should only have to record the current time when adding to the queue and then compare it to the current time at the start or end of processing.

@bluekeyes bluekeyes changed the title Track queue time / event age for asynchronous dispatch Track queue time / event age for async dispatch May 13, 2020
@bluekeyes bluekeyes changed the title Track queue time / event age for async dispatch Track queue time/event age for async dispatch May 13, 2020
@bluekeyes bluekeyes added the enhancement New feature or request label May 13, 2020
@jmcampanini
Copy link
Member

It would also be nice to have a metric for the number of times the capacity limit was hit, to differentiate the 5xx errors from the capacity errors

@bluekeyes
Copy link
Member Author

Good point, something like a github.event.dropped counter that is incremented when the queue is full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants