Bump major version to reflect backcompat break?

[derenrich]

Does this repo follow semantic versioning?

If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break for version 2.3.0?

I just got bit by that backcompat break.

[markelliot]

What break? On Apr 19, 2017, at 10:24 PM, Daniel Erenrich <notifications@github.com<mailto:notifications@github.com>> wrote: Does this repo follow semantic versioning? If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break for version 2.3.0? I just got bit by that backcompat break. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=-wCc7PDlwCN05nXt-_Egv4krxrMFrxQdrreYmMIhBoY&e=>, or mute the thread[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3Qx1HLTXbOAmhKUPkd8JRfydaWsuxks5rxuv8gaJpZM4NCjhG&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=F8Cr9HVqZkIrHoGFdfpfeWweKQYiOXQ4BIDs-G8sS6s&e=>.

[derenrich]

See the release notes for the last release

…

On Wed, Apr 19, 2017, 11:41 PM Mark Elliot ***@***.***> wrote: What break? On Apr 19, 2017, at 10:24 PM, Daniel Erenrich ***@***.*** ***@***.***>> wrote: Does this repo follow semantic versioning? If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break for version 2.3.0? I just got bit by that backcompat break. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub[github.com]< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=-wCc7PDlwCN05nXt-_Egv4krxrMFrxQdrreYmMIhBoY&e=>, or mute the thread[github.com]< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3Qx1HLTXbOAmhKUPkd8JRfydaWsuxks5rxuv8gaJpZM4NCjhG&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=F8Cr9HVqZkIrHoGFdfpfeWweKQYiOXQ4BIDs-G8sS6s&e= >. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2mU5IDYvZ4nP-fQ1Ew490aD7YJH7bks5rxv4LgaJpZM4NCjhG> .

[markelliot]

It might be better called a "change" or an "alert", there was no semver break here. In particular, no code will stop working, compiling, or running/things are still semantically, source and binary compatible. On Apr 20, 2017, at 12:20 AM, Daniel Erenrich <notifications@github.com<mailto:notifications@github.com>> wrote: See the release notes for the last release

On Wed, Apr 19, 2017, 11:41 PM Mark Elliot ***@***.******@***.***>> wrote: What break? On Apr 19, 2017, at 10:24 PM, Daniel Erenrich ***@***.******@***.***> ***@***.***>> wrote: Does this repo follow semantic versioning? If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break for version 2.3.0? I just got bit by that backcompat break. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub[github.com<http://github.com>]< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=-wCc7PDlwCN05nXt-_Egv4krxrMFrxQdrreYmMIhBoY&e=>, or mute the thread[github.com<http://github.com>]< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3Qx1HLTXbOAmhKUPkd8JRfydaWsuxks5rxuv8gaJpZM4NCjhG&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=F8Cr9HVqZkIrHoGFdfpfeWweKQYiOXQ4BIDs-G8sS6s&e= >. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2mU5IDYvZ4nP-fQ1Ew490aD7YJH7bks5rxv4LgaJpZM4NCjhG> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409-23issuecomment-2D295607689&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s=lDDkZqFwy3jBZ_HtOe5dDkfLT1tqC716yjgkz77uaKM&e=>, or mute the thread[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3Q9iUmGFUuHbRuI38F-2DNdLIdLd-5Fz-5Fks5rxwcygaJpZM4NCjhG&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s=chwGbz0swqdFrVtIXRS1BlUdw1sOCGXlaIJzkYl2UfM&e=>.

[derenrich]

My code broke? And then worked when I downgraded? I mean I guess that's not *proof* per se. But ok. On Thu, Apr 20, 2017 at 12:28 AM, Mark Elliot <notifications@github.com> wrote:

…

It might be better called a "change" or an "alert", there was no semver break here. In particular, no code will stop working, compiling, or running/things are still semantically, source and binary compatible. On Apr 20, 2017, at 12:20 AM, Daniel Erenrich ***@***.***< ***@***.***>> wrote: See the release notes for the last release On Wed, Apr 19, 2017, 11:41 PM Mark Elliot ***@***.***< ***@***.***>> wrote: > What break? > > On Apr 19, 2017, at 10:24 PM, Daniel Erenrich ***@***.***< ***@***.***> > ***@***.***>> wrote: > > > Does this repo follow semantic versioning? > > If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break > for version 2.3.0? > > I just got bit by that backcompat break. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub[github.com<http:// github.com>]< > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. com_palantir_http-2Dremoting_issues_409&d=DwMCaQ&c= izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=- wCc7PDlwCN05nXt-_Egv4krxrMFrxQdrreYmMIhBoY&e=>, > or mute the thread[github.com<http://github.com>]< > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. com_notifications_unsubscribe-2Dauth_AAp3Qx1HLTXbOAmhKUPkd8JRfydaWs uxks5rxuv8gaJpZM4NCjhG&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXB rZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m= ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s= F8Cr9HVqZkIrHoGFdfpfeWweKQYiOXQ4BIDs-G8sS6s&e= > >. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#409 issuecomment-295599161>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAE2mU5IDYvZ4nP- fQ1Ew490aD7YJH7bks5rxv4LgaJpZM4NCjhG> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub[github.com]<https:// urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ palantir_http-2Dremoting_issues_409-23issuecomment-2D295607689&d=DwMFaQ&c= izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s= lDDkZqFwy3jBZ_HtOe5dDkfLT1tqC716yjgkz77uaKM&e=>, or mute the thread[ github.com]<https://urldefense.proofpoint.com/v2/ url?u=https-3A__github.com_notifications_unsubscribe- 2Dauth_AAp3Q9iUmGFUuHbRuI38F-2DNdLIdLd-5Fz-5Fks5rxwcygaJpZM4NCjhG&d= DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s= chwGbz0swqdFrVtIXRS1BlUdw1sOCGXlaIJzkYl2UfM&e=>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2me55h2tzmRcCfCGI4qUVfz0makHhks5rxwkigaJpZM4NCjhG> .

[markelliot]

What broke? On Apr 20, 2017, at 12:36 AM, Daniel Erenrich <notifications@github.com<mailto:notifications@github.com>> wrote: My code broke? And then worked when I downgraded? I mean I guess that's not *proof* per se. But ok. On Thu, Apr 20, 2017 at 12:28 AM, Mark Elliot <notifications@github.com<mailto:notifications@github.com>> wrote:

It might be better called a "change" or an "alert", there was no semver break here. In particular, no code will stop working, compiling, or running/things are still semantically, source and binary compatible. On Apr 20, 2017, at 12:20 AM, Daniel Erenrich ***@***.******@***.***>< ***@***.***>> wrote: See the release notes for the last release On Wed, Apr 19, 2017, 11:41 PM Mark Elliot ***@***.******@***.***>< ***@***.***>> wrote: > What break? > > On Apr 19, 2017, at 10:24 PM, Daniel Erenrich ***@***.******@***.***>< ***@***.***> > ***@***.***>> wrote: > > > Does this repo follow semantic versioning? > > If so shouldn't we be on 3.0.0 now given remoting took a backcompat-break > for version 2.3.0? > > I just got bit by that backcompat break. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub[github.com<http://github.com><http:// github.com<http://github.com>>]< > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. com_palantir_http-2Dremoting_issues_409&d=DwMCaQ&c= izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s=- wCc7PDlwCN05nXt-_Egv4krxrMFrxQdrreYmMIhBoY&e=>, > or mute the thread[github.com<http://github.com><http://github.com>]< > https://urldefense.proofpoint.com/v2/url?u=https-3A__github. com_notifications_unsubscribe-2Dauth_AAp3Qx1HLTXbOAmhKUPkd8JRfydaWs uxks5rxuv8gaJpZM4NCjhG&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXB rZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m= ZIiREkoqVxeHAaaDqu_ofZfLszt37T-5MskMhXcBDLw&s= F8Cr9HVqZkIrHoGFdfpfeWweKQYiOXQ4BIDs-G8sS6s&e= > >. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#409 issuecomment-295599161>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAE2mU5IDYvZ4nP- fQ1Ew490aD7YJH7bks5rxv4LgaJpZM4NCjhG> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub[github.com<http://github.com>]<https:// urldefense.proofpoint.com/v2/url?u=https-3A__github.com_<http://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_> palantir_http-2Dremoting_issues_409-23issuecomment-2D295607689&d=DwMFaQ&c= izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s= lDDkZqFwy3jBZ_HtOe5dDkfLT1tqC716yjgkz77uaKM&e=>, or mute the thread[ github.com<http://github.com>]<https://urldefense.proofpoint.com/v2/ url?u=https-3A__github.com_notifications_unsubscribe- 2Dauth_AAp3Q9iUmGFUuHbRuI38F-2DNdLIdLd-5Fz-5Fks5rxwcygaJpZM4NCjhG&d= DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp- VF3pIYG92B19LcCw6XKeYC0U&m=aC0orAFs7YmflFXI1dai_vW9nimZ6USkc8YO51MgNV0&s= chwGbz0swqdFrVtIXRS1BlUdw1sOCGXlaIJzkYl2UfM&e=>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#409 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE2me55h2tzmRcCfCGI4qUVfz0makHhks5rxwkigaJpZM4NCjhG> .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409-23issuecomment-2D295611365&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=7d2ax589hyXaJxg8Ipi33IRT3ey3ZeVnYDehpaqG2ok&s=mFZurrSZlz53Q8QSFk-tMdQ_9cBR0AQLB7So-Lw_kh0&e=>, or mute the thread[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3QzjTI0oeCQFG7ExiJHI2g6FduOAkks5rxwr4gaJpZM4NCjhG&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=7d2ax589hyXaJxg8Ipi33IRT3ey3ZeVnYDehpaqG2ok&s=DB_uV2DuvqiYNgZvBO6AT69IYyJvD-0KQMWiM3LQiI4&e=>.

[derenrich]

I mean the change requires that user's of the library to install the Http2Agent whereas before it was installed for you.

• The framework using remoting should be responsible for installing the
  Http2Agent (for example witchcraft or spark-module-lib), as to ensure
  that it is done early enough.

I hit this issue when upgrading from an older version of witchcraft. While I still think this should be bumped in retrospect at this point bumping it won't solve any problems so I'm closing this.

[ash211]

I had to make two changes to accommodate this:

• add dependency on compile 'com.palantir.remoting2:http2-agent'
• put this as a static block on the class with my main method:

static {
    Http2Agent.install();
}

[markelliot]

Neither change was required, though, http 1.1 support would've continued to give you full functionality. On Apr 20, 2017, at 9:56 AM, Andrew Ash <notifications@github.com<mailto:notifications@github.com>> wrote: I had to make two changes to accommodate this: * add dependency on compile 'com.palantir.remoting2:http2-agent' * put this as a static block on the class with my main method: static { Http2Agent.install(); } — You are receiving this because you commented. Reply to this email directly, view it on GitHub[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_issues_409-23issuecomment-2D295812958&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=WZ2_jPd8gHQjzsoyy9D8jyp5P22b_f4L419Dh6c04n4&s=gtSz6H2VIN1ty8Sy_2cXWkIVdKQzfK8Pa2vaaRT0-7A&e=>, or mute the thread[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAp3Qz4WIt2xSXTVW4pDGz8CelME5Dvgks5rx45AgaJpZM4NCjhG&d=DwMFaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=WZ2_jPd8gHQjzsoyy9D8jyp5P22b_f4L419Dh6c04n4&s=BuTWVkBKH79_HmtAT0qLEW8e_Z7asslaw9bSOc_Eb1U&e=>.