Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict approvals from the PR contributors even if contributor is not the owner of the PR #583

Closed
atul-tw opened this issue May 26, 2023 · 2 comments

Comments

@atul-tw
Copy link

atul-tw commented May 26, 2023

Currently, if I am a contributor to the PR for which owner is someone is else then with my approval the PR gets approved.

@bluekeyes
Copy link
Member

By default, Policy Bot does not allow approvals from the author/owner of a PR or from contributors on the PR. There are three options you can set in the policy to control this behavior:

  • allow_author - if true, the author/owner of the PR can approve
  • allow_contributor - if true, the author/owner and any contributors to the PR can approve
  • allow_non_author_contributor - if true, contributors to the PR can approve, but the author/owner cannot approve

These options apply to each rule, so some rules may allow contributor approvals while others do not. Are any of these options set in your policy?

@atul-tw
Copy link
Author

atul-tw commented May 26, 2023

Oh great... Thanks for providing these inputs...!!!

@atul-tw atul-tw closed this as completed May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants