Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-wrap-multiline is a breaking change #51

Closed
lukevenn opened this issue Dec 16, 2016 · 2 comments
Closed

jsx-wrap-multiline is a breaking change #51

lukevenn opened this issue Dec 16, 2016 · 2 comments

Comments

@lukevenn
Copy link

Hi,

Just wondered if you're using semantic versioning? We are extending tslint-react using version 2.*. The new jsx-wrap-multiline rule in 2.1 is causing our builds to fail without us making any changes to the default value which I believe should make it a breaking change. Am I wrong?

Thanks,
Luke
@adidahiya
Copy link
Contributor

adidahiya commented Dec 16, 2016 •
edited
Loading

Hey, sorry about that -- so far I've been treating tslint-react.json like tslint:latest, which does not follow semver. I suppose it'd be nice to introduce the same semantics as the core configurations, where you have the option of a stable or a bleeding edge configuration, I just haven't gotten around to implementing that. Would likely take a PR for it though.

@adidahiya adidahiya mentioned this issue Mar 10, 2017
Closed
@adidahiya
Copy link
Contributor

closing in favor of #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adidahiya @lukevenn