Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Put docs in .gitignore. #1968

Closed
andy-hanson opened this issue Jan 2, 2017 · 2 comments · Fixed by #2069
Closed

Put docs in .gitignore. #1968

andy-hanson opened this issue Jan 2, 2017 · 2 comments · Fixed by #2069

Comments

@andy-hanson
Copy link
Contributor

andy-hanson commented Jan 2, 2017

This is generated code, so it clutters PRs (that remember to run npm run verify to update docs), and can potentially get out-of-sync with the source (e.g. #1947, which has correct docs but a typo in src).
It also causes merge conflicts when docs/_data/rules.json changes.

@nchen63
Copy link
Contributor

nchen63 commented Jan 2, 2017

If we did this, only docs/_data/rules.json and docs/rules/* should be ignored. Also, if we ignored, we could no longer use /docs on master for gh-pages

@nchen63
Copy link
Contributor

nchen63 commented Jan 18, 2017

just ignoring rules.json for merge conflicts. I think it's still valuable to be able to serve /docs to gh-pages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants