Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Rules that require --type-check should not throw as breaks extends #2169

Closed
SteveALee opened this issue Feb 2, 2017 · 1 comment · Fixed by #2188
Closed

Rules that require --type-check should not throw as breaks extends #2169

SteveALee opened this issue Feb 2, 2017 · 1 comment · Fixed by #2188

Comments

@SteveALee
Copy link

Bug Report

  • TSLint version: 4.4.2
  • TypeScript version: 2.1.5
  • Running TSLint via: CLI / VS Code

TypeScript code being linted

(include if relevant)

with tslint.json configuration:

{
   "rulesDirectory": ["node_modules/tslint-microsoft-contrib"],
   "extends": "tslint-microsoft-contrib/recommended_ruleset.js",
   "rules": {
      "no-for-in-array": false
   }
}

Actual behavior

The throw is annoying anyway as breaks TSLint with little visibility of why in VSCode extension

But more importantly it breaks "extends". TS throws an exception for "no-for-in-array" defined in base recommend_ruleset as --type-check is not enabled even though we tried to disable that check in the derived config.

Expected behavior

Just a warning

@adidahiya
Copy link
Contributor

Makes sense; we should make this UX better.

Linking another issue that discusses related UX problems in running vscode-tslint: https://github.com/Microsoft/vscode-tslint/issues/70

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants