Object Spread should not be preferred when the argument is this.

[snood1205]

Bug Report

• TSLint version: 5.5.0
• TypeScript version: 2.3.3
• Running TSLint via: WebStorm

TypeScript code being linted

const form = Object.assign({}, this);

with tslint.json configuration:

{
    "prefer-object-spread": true
}

Actual behavior

TSLint gives me the message

Use the object spread operator instead. (prefer-object-spread)

Expected behavior

TSLint should be ok with this usage of Object.assign({}, this) because per TS2698, "spread types may only be created from object types."

Somewhat related to this is: #2824

[ajafff]

Have you already searched for or opened a corresponding issue in the typescript repo?
I think this is better fixed in the typescript compiler if they consider this a bug. Otherwise we can add an exception for this case to the rules.

[snood1205]

@ajafff The related TS issues are #10727 and #12756. It seems from the latter that people want support for this but it doesn't really seem to have been fixed thus far at least? I'm not sure if it ever will be fixed.

[ajafff]

The linked PR that adds spread types to typescript looks abandoned. It's reasonable to add an exception to the rule until the compiler supports it.

[ajafff]

Fixed by #3126

[snood1205]

@ajafff Awesome, thank you!