Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Do something against the CircleCI timeouts #3127

Closed
ajafff opened this issue Aug 14, 2017 · 2 comments · Fixed by #3153
Closed

Do something against the CircleCI timeouts #3127

ajafff opened this issue Aug 14, 2017 · 2 comments · Fixed by #3153

Comments

@ajafff
Copy link
Contributor

ajafff commented Aug 14, 2017

Our mocha tests time out quite often on CircleCI. Especially node 0 which tests with node v4.x is prone to fail because it's slower than all other. It's annoying to always restart builds until one eventually succedes.

Some time ago I already increased the timeout for some test cases from 4000 to 8000 ms.
Do we want to increase the timeout further or try some other CI?

@adidahiya adidahiya added this to the TSLint v5.7 milestone Aug 14, 2017
@adidahiya
Copy link
Contributor

adidahiya commented Aug 22, 2017

Which tests are slow? We should skip any tests which rely on an extended timeout (for now) and try to make them faster. I'd prefer to stay on CircleCI.

@ajafff
Copy link
Contributor Author

ajafff commented Aug 22, 2017

I looked through the failed builds of the last weeks. We have a winner: It's the test for tslint --project --fix.
There are some other IO heavy tests that fail occasionally, but >90% of the time it's the first one in the list:

  • Executable --project flag can apply fixes from multiple rules (8000ms)
  • Configuration loadConfigurationFromPath with config not relative to tslint extends with package installed relative to tslint (2000ms)
  • Executable --project flag works with '--exclude' (4000ms)
  • Linter apply fixes to correct files (2000ms)

Possible fix for the first list item: use runner.ts directly instead of spawning a new process. That avoid loading all sources and (de)optimizing them again. Related: #2587

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants