Fix patch() so that the root is patched instead of recreated #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, patch(element, vnode) would create a new element every time for the top-level element, unless the top-level vnode had no id and className. This is because emptyNodeAt() would create a vnode with sel equal to the element's tagName, NOT including id and className. This seems to be just a small fix, however this fix was crucial to get Web Components (custom elements) working with Cycle.js, because the custom element's "create" callback was being called infinitely and recursively, because snabbdom was creating the top-level element every time, even if the sel of oldVNode and vnode were supposed to be the same.
| @@ -670,7 +681,7 @@ describe('snabbdom', function() { | |||
| {remove: function(_, rm) { rm2 = rm; }}, | |||
| ]); | |||
| var vnode1 = h('div', [h('a', {hook: {remove: function(_, rm) { rm3 = rm; }}})]); | |||
| var vnode2 = h('div', []); | |||
| var vnode2 = h('div', []); | |||
There was a problem hiding this comment.
This was my editor that automatically converted the (previously) tab to spaces. But it's anyway good to avoid mixed tabs and spaces.
|
LGTM 👍 |
|
This would potentially fix #158 |
|
Thank you for the PR. To me this seems clearly better. I'd say the old behavior was pretty much a bug. |
|
I've just released 0.5.3 with this patch. Thanks again 😄 I'm sorry for the trouble caused. It never occurred to me how the old behavior could cause issues. |
|
Thanks for merging 👍 the synergy between our communities is good |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, patch(element, vnode) would create a new element every time
for the top-level element, unless the top-level vnode had no id and
className. This is because emptyNodeAt() would create a vnode with sel
equal to the element's tagName, NOT including id and className.
This seems to be just a small fix, however this fix was crucial to get
Web Components (custom elements) working with Cycle.js, because the
custom element's "create" callback was being called infinitely and
recursively, because snabbdom was creating the top-level element every
time, even if the sel of oldVNode and vnode were supposed to be the
same.