Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write dimension when exporting EMPTY to WKT #150

Merged
merged 2 commits into from Sep 18, 2022
Merged

Write dimension when exporting EMPTY to WKT #150

merged 2 commits into from Sep 18, 2022

Conversation

paleolimbot
Copy link
Owner

Fixes #141.

unclass(wk::as_wkt(wk::as_wkb("POLYGON ZM EMPTY")))
#> [1] "POLYGON ZM EMPTY"

Created on 2022-09-18 by the reprex package (v2.0.1)

@codecov-commenter
Copy link

Codecov Report

Base: 98.95% // Head: 98.95% // No change to project coverage 👍

Coverage data is based on head (20db238) compared to base (bb18e2c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          74       74           
  Lines        5172     5172           
=======================================
  Hits         5118     5118           
  Misses         54       54           
Impacted Files Coverage Δ
src/wkt-writer.cpp 99.43% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paleolimbot paleolimbot merged commit 518a8d7 into master Sep 18, 2022
@paleolimbot paleolimbot deleted the zm-empty branch September 18, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WKT writer doesn't write Z(M) for EMPTY
2 participants