Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split post logic and memento parsing into separate functions #12

Closed
wants to merge 2 commits into from

Conversation

tkelman
Copy link

@tkelman tkelman commented Oct 15, 2019

And allow specifying the anyway flag in case you want to retrieve existing archives instead of always creating a new one.

I have a use case where I want to inspect the most-recently-archived date, but don't care much about the URL. Working directly with the POST response object would be easier for me than downloading the same content over again.

And allow specifying the anyway flag in case you want to retrieve
existing archives instead of always creating a new one
@tkelman
Copy link
Author

tkelman commented Oct 17, 2019

Would be happy to get your opinion on this refactor @palewire. This would conflict a little with @adbar's #11 but not in any irreconcilable ways.

@palewire
Copy link
Owner

palewire commented Dec 1, 2019

I'm okay with splitting the functions but I'd prefer not to do the anyway thing. Seems a little hacky for my taste. Could we insert an error to be raised or some kind of warning log you could catch to handle it on your end?

@palewire palewire closed this Dec 1, 2019
@tkelman
Copy link
Author

tkelman commented Dec 1, 2019

Do you have any other proposal for a way to retrieve existing archives? I don't want to unconditionally submit a new one all of the time, I'd like to check the status first. The anyway flag accomplishes that - it's pretty harmless to make the flag user specifiable as long as the default doesn't change, can you clarify what you find objectionable about it?

@tkelman
Copy link
Author

tkelman commented Dec 1, 2019

I can't get the desired behavior for some of my calls to this function with anyway hardcoded to 1. There's no exceptions or log parsing that can do the same thing, I need the option of sending a different value in the post payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants