Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFXProgressBar not updating progress visually #31

Closed
mica-alex opened this issue May 16, 2021 · 10 comments
Closed

MFXProgressBar not updating progress visually #31

mica-alex opened this issue May 16, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@mica-alex
Copy link

mica-alex commented May 16, 2021

Hi,

I am having an issue updating the progress bar to be any value besides indeterminate. I have run a debug on my application and verified the following:

  1. progressBar.setProgress( value ); is called from the JavaFX thread
  2. The internal progressBar.progress and progressBar.indeterminate values appear to be properly updated.

    image
  3. The value specified to progressBar.setProgress( value ) is either the indeterminate value, or is between 0.0 and 1.0.

    image
  4. I have verified that the standard JavaFX progress bar does not experience this behavior, when swapped with the MFXProgressBar (no other code changes)

Despite everything being called and set correctly (I believe), the progress bar always shows as indeterminate in my application.
image

@palexdev
Copy link
Owner

Hello,
Can you provide a reproducible example please?

@mica-alex
Copy link
Author

mica-alex commented May 16, 2021

Hello @palexdev,

I have created a very basic/simple JavaFX application that can reproduce the errorproblem. This basic/simple application uses the same library versions and JavaFX structure I use in the full application.

I did the work in IntelliJ IDEA, although I includes the pom.xml file for Maven as well. All that is required is to run GUIWindow.main(), as that extends the JavaFX Application class.

test-jfx-mfx-prog-bar-update-issues.zip

@palexdev
Copy link
Owner

Hello @palexdev,

I have created a very basic/simple JavaFX application that can reproduce the errorproblem. This basic/simple application uses the same library versions and JavaFX structure I use in the full application.

I did the work in IntelliJ IDEA, although I includes the pom.xml file for Maven as well. All that is required is to run GUIWindow.main(), as that extends the JavaFX Application class.

test-jfx-mfx-prog-bar-update-issues.zip

Got it, there's a missing listener in the skin
The fix will be included in the next release

2021-05-17.02-15-48_Trim.mp4

@mica-alex
Copy link
Author

Amazing, thank you for the prompt responses and fixes! I am excited for the next release.

@mica-alex
Copy link
Author

Hi,

Just to follow up on this, I saw a similar behavior when updating the items on the ComboBox. I do not have a reproducible example of that one though, because I ended up needing to switch GUIs and come back, which bypassed the issue. I’m not sure if I was doing something incorrectly, but I figured I’d mention it.

Again, thank you for the super quick responses and handling. I’m transitioning my entire application to MaterialFX now because of the ease of use, and I no longer need a collection of add-exports compiler arguments as with JFoenix. Amazing work with MaterialFX!

@palexdev
Copy link
Owner

Can at least tell me if it was LegacyComboBox or the new one?
By updating items you mean changing the items list?

@mica-alex
Copy link
Author

Sorry for not clarifying. It is the new combo box, and it is when updating items in the items list

@palexdev
Copy link
Owner

Got it, forgot to add the listeners to the items property in case they change
Will fix it in the next release

@palexdev palexdev added the bug Something isn't working label May 17, 2021
@mica-alex
Copy link
Author

Great! Thank you again. I'm glad I found this project.

@palexdev
Copy link
Owner

palexdev commented Jun 7, 2021

Fixed in latest release

@palexdev palexdev closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants