Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #169

Closed
gtolarc opened this issue Jan 15, 2021 · 4 comments
Closed

i18n support #169

gtolarc opened this issue Jan 15, 2021 · 4 comments
Assignees
Labels
Admin admin package feature New feature or request help wanted Extra attention is needed
Projects

Comments

@gtolarc
Copy link
Contributor

gtolarc commented Jan 15, 2021

I think i18n support is needed.
It would be nice if both system messages and data model field names could be supported by a common interface.

I think the following is a good example.
https://marmelab.com/react-admin/Translation.html#translation-messages
https://marmelab.com/react-admin/Translation.html#translating-resource-and-field-names

Could you guys add this part to the roadmap?

@AhmedElywa AhmedElywa self-assigned this Jan 15, 2021
@AhmedElywa AhmedElywa added the feature New feature or request label Jan 15, 2021
@AhmedElywa AhmedElywa added this to To do in Dashboard via automation Jan 15, 2021
@AhmedElywa AhmedElywa added the help wanted Extra attention is needed label Jan 15, 2021
@AhmedElywa
Copy link
Collaborator

This is a big change and needs time.
I think maybe you can help when I start on this.

@gtolarc
Copy link
Contributor Author

gtolarc commented Jan 15, 2021

Sure :)

@gtolarc
Copy link
Contributor Author

gtolarc commented Jan 28, 2021

Since adminSettings.json is saved as a file, CMS cannot be separated unless we use a SSR framework like nextjs. Also, it is impossible to scale up server instance. But how about rethinking it as the role of a static generator to make setting easier?

If we can determine permissions or settings(label, upload, editor, etc..) only at the coding stage as a js file, we can apply the existing i18n libraries and many things will be solved.

Other headless cms tools have a similar orm-like approach that describes the appearance of the db schema and the front view at once, but I like the pal.js method where everything is automatically created with prisma as idl. So, how about keeping this concept, but changing only adminSettings.json to the js file and removing the settings at the user level. What do you think? @AhmedElywa

@AhmedElywa AhmedElywa moved this from To do to In progress in Dashboard Apr 3, 2021
@AhmedElywa AhmedElywa added the Admin admin package label Apr 3, 2021
@AhmedElywa
Copy link
Collaborator

resolved in last version

Dashboard automation moved this from In progress to Done Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin admin package feature New feature or request help wanted Extra attention is needed
Projects
Dashboard
  
Done
Development

No branches or pull requests

2 participants