doc: add shared examples for line checking #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benebrice
force-pushed
the
doc--line-checker
branch
2 times, most recently
from
a0782fc
to
9753980
Compare
Signed-off-by: Brice <brice.bene@gmail.com>
benebrice
force-pushed
the
doc--line-checker
branch
from
9753980
to
c4fb55c
Compare
palkan
reviewed
Jan 11, 2022
| ```ruby | ||
| RSpec.describe V1::MyDelivery do | ||
| context "when..." do | ||
| it_behaves_like "deliverable", [:mailer], [:some_action] |
There was a problem hiding this comment.
I like the idea.
Can we make the API a bit more explicit? For example:
# single line
it_behaves_like "deliverable", via: :mailer, action: :some_action
# multiple lines
it_behaves_like "deliverable", via: [:mailer, :pusher], action: :some_actionBtw, what is the case for multiple actions? I think, the most common case is to check for a single action; hence, for multiple actions we can just include the shared example multiple times.
There was a problem hiding this comment.
Sorry I forgot this one! I'll take a look asap. 🙂
For the multiple actions, it was only to avoid to copy/paste the same shared example.
There was a problem hiding this comment.
No worries. I think, we can actually merge this.
palkan
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.