Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream RES compatibility #3

Closed
palkan opened this issue Sep 23, 2020 · 7 comments · Fixed by #6
Closed

Fix upstream RES compatibility #3

palkan opened this issue Sep 23, 2020 · 7 comments · Fixed by #6
Assignees
Labels
enhancement New feature or request

Comments

@palkan
Copy link
Owner

palkan commented Sep 23, 2020

Looks like events serialization internals are going to change in the future RES releases (for example, RailsEventStore/rails_event_store#760).

Currently, our edge builds are broken: https://github.com/palkan/active_event_store/runs/1148181711

@palkan palkan added the enhancement New feature or request label Sep 23, 2020
@palkan palkan self-assigned this Sep 23, 2020
@palkan
Copy link
Owner Author

palkan commented Sep 23, 2020

Hey @pawelpacana! When do you plan to release the new version with the above mentioned changes?

Is there a changelog/upgrade notes somewhere, so we can prepare for the upgrade?

@mostlyobvious
Copy link

mostlyobvious commented Sep 28, 2020

Hey!

There will be a changelog and the release with breaking changes will be released as 2.0. I haven't looked into it yet in detail but we'll most likely release 1.99 first with deprecation notices and backward compatibility if possible.

I'll keep you posted

@palkan
Copy link
Owner Author

palkan commented Sep 29, 2020

@pawelpacana Thank you!

@mostlyobvious
Copy link

No 1.99 release. Deprecations messages where possible in 2.0 release but it still requires changes in a database structure. Please have a look at RailsEventStore/rails_event_store#791 for changelogs.

@apauly
Copy link

apauly commented Sep 6, 2021

Hey @palkan!
As expected, newer version of RES will cause an exception (missing keyword: :serializer). It seems the latest supported version is 1.3.1 (I cannot find a 1.99).

Is this still actively maintained?
If so, I'd consider creating a PR to support newer RES versions as well :)

@palkan
Copy link
Owner Author

palkan commented Sep 7, 2021

Is this still actively maintained?

Kind of: we're still using this gem in some projects but me personally not involved.

I'd consider creating a PR to support newer RES versions as well :)

That would be awesome!

@mostlyobvious
Copy link

@apauly If you have any questions regarding RES on this, feel free to ping me here or drop in on our discord or forum 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants