Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has many through support #120

Closed
davidpatters0n opened this issue Apr 9, 2019 · 2 comments
Closed

Has many through support #120

davidpatters0n opened this issue Apr 9, 2019 · 2 comments

Comments

@davidpatters0n
Copy link

Following up from: #45 is there any plans for adding support for has_many through associations?

@palkan
Copy link
Owner

palkan commented Apr 12, 2019

any plans for adding support for has_many through associations?

Is this not supported already? Although we don't have tests for that (yet), the implementation doesn't check for any particular association types:

association.singleton_class.prepend Logidze::VersionedAssociation
if association.is_a? ActiveRecord::Associations::CollectionAssociation
association.singleton_class.prepend(
Logidze::VersionedAssociation::CollectionAssociation
)
end
(has_many through: is a CollectionAssociation)

@davidpatters0n
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants