Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percentage and total test time to EventProf #100

Closed
palkan opened this issue Oct 10, 2018 · 3 comments
Closed

Add percentage and total test time to EventProf #100

palkan opened this issue Oct 10, 2018 · 3 comments
Labels
hacktoberfest It's pumpkin time!

Comments

@palkan
Copy link
Collaborator

palkan commented Oct 10, 2018

Add a percentage of time spent in the event (from the total test suite/group/example time)

Before:

[TEST PROF INFO] EventProf results for factory.create

Total time: 03:07.353
Total events: 7459

Something (./my_spec.rb:21) – 09:16.100 (7 / 3)
...

After:

[TEST PROF INFO] EventProf results for factory.create

Total time: 03:07.353 of 07:25:232 (42.02%)
Total events: 7459

Something (./my_spec.rb:21) – 09:16.100 (7 / 3) of 12:29:233 (74.13%)
...
@palkan palkan created this issue from a note in TestProf Development (Next Release) Oct 10, 2018
@palkan palkan added the hacktoberfest It's pumpkin time! label Oct 10, 2018
@dmagro
Copy link
Contributor

dmagro commented Oct 15, 2018

Hello there! May I take a look at this one?
Could you get into more details? I'm trying to understand what do you mean by total test time.

@palkan
Copy link
Collaborator Author

palkan commented Oct 15, 2018

Hi!

May I take a look at this one?

Sure)

I'm trying to understand what do you mean by total test time.

That's the total time the test suite took (i.e. the sum of all examples total time spent).

@dmagro
Copy link
Contributor

dmagro commented Oct 20, 2018

@palkan could you take a look at my PR?

TestProf Development automation moved this from Next Release to Done Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest It's pumpkin time!
Projects
No open projects
Development

No branches or pull requests

2 participants