Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Formatting for <select> #42

Closed
tti0 opened this issue Mar 4, 2018 · 1 comment
Closed

[FEATURE] Formatting for <select> #42

tti0 opened this issue Mar 4, 2018 · 1 comment

Comments

@tti0
Copy link
Contributor

tti0 commented Mar 4, 2018

Section(s)

This issue works on the marked sections of Magic [PICK ONE OR MORE]:

  • Components (e.g. box, button, errors)

Type

This issue is a feature proposal

Description

Mainly for CodeDragon purposes, but certainly useful to other Magic users as well.
Could nicer-than-default formatting please be added to the <select> HTML form element, in a similar way to the default formatting on <input type="checkbox"> and <input type="text"> currently works. See screenshot for comparison below, from CodeDragon.

image

Thanks!
@tti0

@palkerecsenyi
Copy link
Owner

Of course! I think in the example picture you are using Firefox, which styles selects differently to other browsers. In Chrome, you'll find that Magic already applies minor styling to selects - the amount of styling applicable to them is minimal. Frameworks like Materlialize use heavy custom JS to completely re-style selects, while Magic strictly involves no JS. I'll try my best to add some custom styling. Here are current Magic styles for selects:

select {
  font-size: 20px;
  margin-bottom: 10px;
  border-radius: 4px;
  font-family: "Noto", "Roboto", sans-serif;
  outline: none;
  transition: all .3s ease;
  padding-right: 5px; }

select:hover {
  background-color: #F3F3F3; }

select:focus {
  background-color: transparent !important;
  box-shadow: 0 0 0 3px rgba(170, 170, 170, 0.5); }

select option {
  transition: all .3s ease;
  padding: 5px; }

@palkerecsenyi palkerecsenyi changed the title Feature request: Formatting for <select> [FEATURE] Formatting for <select> Mar 4, 2018
Development automation moved this from To do to Completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Completed
Development

No branches or pull requests

2 participants